Remove Timex.before? and Timex.after? #4552
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Sep 9, 2024
| @@ -18,7 +18,7 @@ defmodule Plausible.Billing.Quota.Limits do | |||
|
|
|||
| @spec site_limit(User.t()) :: non_neg_integer() | :unlimited | |||
| def site_limit(user) do | |||
| if Timex.before?(user.inserted_at, @limit_sites_since) do | |||
| if Date.before?(user.inserted_at, @limit_sites_since) do | |||
There was a problem hiding this comment.
@limit_sites_since is a date -- ~D[2021-05-05] -- and user.inserted_at is a naive datetime.
Comparisons use "least common denominator" sort-of logic, so Date module needs to be used to compare the two.
ruslandoga
force-pushed
the
rm-timex-before-after
branch
from
7e0ee1f
to
69c8376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #4338
Changes
This PR continues the removal of Timex by replacing Timex.before? and Timex.after? with similar Date and NaiveDateTime functions.
Tests
Changelog
Documentation
Dark mode